[jira] [HIVE-3772] Fix a concurrency bug in LazyBinaryUtils due to a static field (patch by Reynold Xin)
Needs ReviewPublic

Press ? to show keyboard shortcuts.
Author
mbautin
Reviewers
ashutoshc
njain
raghotham
JIRA
zshao
heyongqiang
nzhang
jsichi
pauly
amareshwarisr
cwsteinbach
Lint
Lint Skipped
Unit
Unit Tests Skipped
Branch
trunk-hive-3772-fix-concurrency-bug-in-lazybinaryutils
Apply Patch
arc patch D7155
Arcanist Project
Restricted Arcanist Project
Subscribers
None
Projects
None
Summary

Reynold Xin's patch needed by the Shark project. https://github.com/amplab/hive/commit/17e1c3dd2f6d8eca767115dc46d5a880aed8c765
(writeVLong should not use a static field due to concurrency concerns.)

Test Plan

Unit tests

dhruba resigned from this revision.Via LegacyDec 17 2012, 10:08 PM
zshao requested changes to this revision.Via LegacyDec 21 2012, 7:53 PM

Please take this opportunity to fix all static variables in this file.

By the way, a better way to fix is to use ThreadLocal. That's more effiicient because then we don't need to call new in these low-level functions.

serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
126

Is this a problem for multi-threaded access as well?

mbautin updated this revision.Via LegacyJan 3 2013, 11:53 PM

Addressing Zheng's comment by using ThreadLocal.

Revision Update History

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1229831417235Dec 5 2012, 7:32 AM
Diff 2249391427681Addressing Zheng's comment by using ThreadLocal.Jan 3 2013, 11:52 PM

Local Commits

CommitTreeParentsAuthorSummaryDate
83683e5f97a915ebc89aef95af0162d79eadMikhail Bautin
[HIVE-3772] Fix a concurrency bug in LazyBinaryUtils due to a static field
Dec 30 2012, 11:34 PM

Table of Contents

Diff 24939

serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java

Loading...

Add Comment