[jira] [HIVE-3384] HIVE JDBC module won't compile under JDK1.7 as new methods added in JDBC specification
AbandonedPublic

Press ? to show keyboard shortcuts.
Author
mbautin
Reviewers
cdrome
weidongbian
JIRA
ashutoshc
Lint
Lint Skipped
Unit
Unit Tests Skipped
Branch
arcpatch-D6873
Apply Patch
arc patch D6873
Arcanist Project
Restricted Arcanist Project
Subscribers
None
Projects
None
Summary
Test Plan

Hive unit tests

ashutoshc requested changes to this revision.Via LegacyNov 28 2012, 7:59 AM

Patch looks good. Couple of minor comments.

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
49

Unneeded import.

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
29

Duplicate import

metastore/build.xml
106

Why UseSplitVerifier is required? Unless there is a strong reason for this I will recommend to get rid of this, since this flag is specific to Oracle JVM, we should avoid vendor specific flag for better portability.

mbautin added inline comments.Via LegacyNov 28 2012, 6:03 PM
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java
49

Removed.

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java
29

Removed.

metastore/build.xml
106

Unfortunately, this seems to be required in order to run unit tests under JDK 7. Without this, verification errors such as P87 start happening, presumably because some of the dependencies have been compiled using an earlier version of javac and do not pass the more strict verification guidelines Java 7 uses by default.

mbautin updated this revision.Via LegacyNov 28 2012, 6:13 PM

Addressing Ashutosh's comments.

mbautin updated this revision.Via LegacyNov 28 2012, 6:42 PM

Adding another -XX:-UseSplitVerifier for unit tests to work on JDK7.

ashutoshc requested changes to this revision.Via LegacyNov 29 2012, 9:01 AM

One more comment. Patch looks good otherwise.

build-common.xml
440

Instead of hardcoding jvmarg I will suggest to define a variable here $jvm.args and add it in build.properties with default value set to -XX:-UseSplitVerifier that way folks can override this value if they want (e.g. for non-Oracle jdks)

metastore/build.xml
106

Instead of hardcoding jvmarg I will suggest to define a variable here $jvm.args and add it in build.properties with default value set to -XX:-UseSplitVerifier that way folks can override this value if they want (e.g. for non-Oracle jdks)

mbautin updated this revision.Via LegacyNov 29 2012, 10:20 PM

Addressing Ashutosh's additional comment: putting -XX:-UseSplitVerifier into jvm.args defined in build.properties.

mbautin updated this revision.Via LegacyNov 30 2012, 9:19 PM

Rebasing on trunk changes.

mbautin updated this revision.Via LegacyDec 3 2012, 6:58 AM

Reverting an unnecessary change of a value attribute to a line attribute.

mbautin updated this revision.Via LegacyDec 4 2012, 8:19 AM

Addressing Ashutosh's comment from http://bit.ly/ViwEHf: setting jvm.args when running PluginTest from the pdk module.

mbautin abandoned this revision.Via LegacyDec 12 2012, 8:17 PM

Committed into Hive trunk and 0.9 branches.

Revision Update History

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1222451411592Nov 21 2012, 7:47 AM
Diff 2226051414608Addressing Ashutosh's comments.Nov 28 2012, 6:12 PM
Diff 3226171414608Adding another -XX:-UseSplitVerifier for unit tests to work on JDK7.Nov 28 2012, 6:42 PM
Diff 4227191414608Addressing Ashutosh's additional comment: putting -XX:-UseSplitVerifier into jvm.args defined in build.properties.Nov 29 2012, 10:18 PM
Diff 5227491415278Rebasing on trunk changes.Nov 30 2012, 9:18 PM
Diff 6228151415917Reverting an unnecessary change of a value attribute to a line attribute.Dec 3 2012, 6:57 AM
Diff 7228691416377Addressing Ashutosh's comment from http://bit.ly/ViwEHf: setting jvm.args when running PluginTest from the pdk module.Dec 4 2012, 8:17 AM

Local Commits

CommitTreeParentsAuthorSummaryDate
a8722c5bca4d1f7e12788abaf139d51c2aabMikhail Bautin
HIVE-3384 addendum: specify jvm.args in build-plugin.xml if not set
Dec 4 2012, 7:19 AM
f139d51c2aab3956bf24b493e08ab06b609embautin
HIVE-3384 Hive JDBC module won't compile under JDK1.7 as new methods added in… (Show More…)
Dec 3 2012, 2:22 AM

Diff 22869

build-common.xml

Loading...

build.properties

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveBaseResultSet.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveCallableStatement.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveConnection.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDataSource.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDatabaseMetaData.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveQueryResultSet.java

Loading...

jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveStatement.java

Loading...

metastore/build.xml

Loading...

pdk/scripts/build-plugin.xml

Loading...

Add Comment