HIVE-5567 [jira] Add better protection code for SARGs
AcceptedPublic

Press ? to show keyboard shortcuts.
Next Step
arc land 'h-5567'
Author
omalley
Reviewers
JIRA
hagleitn
Lint
Lint OK
Unit
No Unit Test Coverage
Branch
h-5567
Apply Patch
arc patch D13479
Arcanist Project
Restricted Arcanist Project
Subscribers
None
Projects
None
Summary

HIVE-5567. Add better protection code for SARGs.

Currently, the SARG parser gets a NPE when the push down predicate uses a type like decimal that isn't supported.

Test Plan

EMPTY

hagleitn accepted this revision.Via LegacyOct 16 2013, 11:24 PM

Looks good except for minor test issue.

ql/src/test/queries/clientpositive/orc_create.q
69

did you mean to change this to decimal? i'm guessing you want an int test too.

omalley updated this revision.Via LegacyOct 16 2013, 11:38 PM

Fixed the test case to keep the int column

omalley updated this revision.Via LegacyOct 17 2013, 8:54 PM

Fixed the ordering to fix TestSearchArgumentImpl

hagleitn added a comment.Via LegacyOct 17 2013, 9:37 PM

LGTM

Revision Update History

DiffIDBaseDescriptionCreatedLintUnit
BaseBase
Diff 1416371532839Oct 16 2013, 8:48 PM
Diff 2416851532839Fixed the test case to keep the int columnOct 16 2013, 11:38 PM
Diff 3417811532839Fixed the ordering to fix TestSearchArgumentImplOct 17 2013, 8:54 PM

Local Commits

CommitTreeParentsAuthorSummaryDate
4bf1770193e966da7e748da7bf262baa41fbOwen O'Malley
HIVE-5567 [jira] Add better protection code for SARGs (Show More…)
Oct 16 2013, 8:46 PM

Diff 41781

data/files/orc_create_people.txt

Loading...

ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java

Loading...

ql/src/test/queries/clientpositive/orc_create.q

Loading...

ql/src/test/results/clientpositive/orc_create.q.out

Loading...

Add Comment